Opened on 06/19/2015 at 03:50:24 PM
Closed on 07/23/2015 at 01:02:15 PM
#2698 closed defect (worksforme)
Notifications do not display included links
| Reported by: | Ross | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | #2162 | Platform: | Firefox |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by Ross)
Environment
ABP 2.6.9.3953
Firefox 38.0.5 / Windows 8.1 x64
How to reproduce
- Set up the notification below on the server.
- In Firefox, navigate to about:config.
- Reset the adblockplus.notificationdata key.
- Restart Firefox.
- Wait one minute for the notification data to be fetched.
- Observe the response includes the link as expected.
- Observe the notification displayed by ABP does not display the link.
Test data
severity = information target = extension=adblockplus title.en-US = Test notification message.en-US = Test notification with link links = adblock_browser_android_beta_community
Observed behaviour
The notification displayed by ABP does not display the link.
Expected behaviour
The notification displayed by ABP should display the link.
Attachments (1)
Change History (7)
Changed on 06/19/2015 at 03:50:44 PM by Ross
comment:1 Changed on 06/19/2015 at 03:59:15 PM by fhd
- Resolution set to rejected
- Status changed from new to closed
comment:2 follow-up: ↓ 3 Changed on 06/22/2015 at 12:29:22 PM by Ross
- Blocking 2162 added
- Description modified (diff)
- Resolution rejected deleted
- Status changed from closed to reopened
Retested with "doc links". They are still not displayed in the notification at all.
comment:3 in reply to: ↑ 2 Changed on 06/22/2015 at 05:08:43 PM by greiner
- Cc greiner added
Replying to Ross:
Retested with "doc links". They are still not displayed in the notification at all.
The message doesn't contain any <a> tags. Note that not only do you need to specify where it should link to but also which part of the text should be hyperlinked.
e.g. Test notification with <a>link</a>
comment:4 Changed on 06/29/2015 at 05:03:44 AM by Ross
- Resolution set to worksforme
- Status changed from reopened to closed
Ah, that makes sense and works as expected (tested single and multiple links).
ABP 2.6.9.3953
Firefox 38.0.5 / Windows 8.1 x64
comment:5 Changed on 07/23/2015 at 01:00:31 PM by fhd
- Resolution worksforme deleted
- Status changed from closed to reopened
- Tester set to Unknown
comment:6 Changed on 07/23/2015 at 01:02:15 PM by fhd
- Resolution set to worksforme
- Status changed from reopened to closed
Woops, sorry, closing again.
That is actually by design: Notifications can only show "doc links". Meaning. links reachable via https://adblockplus.org/redirect?link=foo.
For example, the entry:
links = adblock_browser_android_beta_community
Would end up linking to: https://adblockplus.org/redirect?link=adblock_browser_android_beta_community