Opened on 06/21/2015 at 12:39:18 PM
Closed on 06/22/2015 at 01:02:50 PM
#2702 closed defect (rejected)
abp_rewrite.py does not work with python 2.6
| Reported by: | Mailkov | Assignee: | Mailkov |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | goodfirstbug |
| Cc: | sebastian, trev | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
O.S. WINDOWS 7
Python 2.6
How to reproduce
- Clone repository libadblockplus from github
- First update dependencies
- Use my fix ensure_dependencies.py (see: https://github.com/adblockplus/buildtools/pull/4 ) on all repository
- Launch createsolution
- Compile solution on build/ia32 or build/x64
- Compile returns error on convert_js.py caused by abp_rewrite.py
Observed behaviour
Compile returns error on convert_js.py caused by abp_rewrite.py
Expected behaviour
Compile is ok
Attachments (0)
Change History (7)
comment:1 Changed on 06/21/2015 at 12:52:35 PM by sebastian
- Cc sebastian added
- Component changed from Unknown to Build-and-Release-Tools
- Keywords goofirstbug added
- Owner set to Mailkov
- Priority changed from Unknown to P4
- Ready set
comment:2 Changed on 06/21/2015 at 12:52:45 PM by sebastian
- Keywords goodfirstbug added; goofirstbug removed
comment:3 Changed on 06/21/2015 at 12:53:11 PM by Mailkov
comment:4 Changed on 06/21/2015 at 12:53:50 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 follow-up: ↓ 6 Changed on 06/21/2015 at 05:16:56 PM by trev
- Cc trev added
@sebastian: Why is this considered a valid bug? We require Python 2.7 consistently throughout our codebase - there are no supported environments limited to Python 2.6. IMHO this is a documentation issue if anything.
comment:6 in reply to: ↑ 5 Changed on 06/21/2015 at 05:28:09 PM by Mailkov
Replying to trev:
@sebastian: Why is this considered a valid bug? We require Python 2.7 consistently throughout our codebase - there are no supported environments limited to Python 2.6. IMHO this is a documentation issue if anything.
In libadblockplus or adblockplusie
the readme file speaks about Python 2.6
if is not You change in readme file ....
comment:7 Changed on 06/22/2015 at 01:02:50 PM by sebastian
- Ready unset
- Resolution set to rejected
- Status changed from reviewing to closed
For the record: We discussed this yesterday on IRC. And in fact it turned out to be a documentation issue, that some of our README files mentioned Python 2.x, instead 2.7. This has been changed now. Though I initially thought that it wouldn't hurt to support Python 2.6 at least where it's possible without additional complexity. However, that would mean that we have to test future change with Python 2.6, which would be rather pointless.
I fix it!
pull request: https://github.com/adblockplus/jshydra/pull/2