Share dialog fails to open on first-run page

[passbrains]

Adapted from ​https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-138

Environment

Windows + 8 64bit + Firefox + English
ABP version 2.6.9.3945

How to reproduce

1. Go to chrome://adblockplus/content/ui/firstRun.html
2. Click on Facebook, Twitter or Google+ icon. 

Observed behaviour

Share dialog is not opened.

Expected behaviour

Share dialog is opened.

What to change

adblockplusui

• Add ​WebChannel listener for triggering popupMessageListener function on Gecko-based platforms.

share.adblockplus.org

• Catch exception thrown by window.parent.postMessage.
• Call window.dispatchEvent using ​a custom WebChannel event in case of an exception.

What to test

Clicking on social media icon on first-run page in each of the following platforms should open the share dialog:

• Chrome / Opera / Safari (requires dependency update)
• Firefox 29
• Firefox 42
• Firefox Mobile
• SeaMonkey
• Thunderbird

[passbrains]

1 - 31 May 2015 10:24:47 posted by Rajeswari Vemuri
Similar to AFI-37

[Shikitita]

Reproduced on the Testfabrik machine Win vista 64 bit slot 5 with Firefox 38.0.5. Spotted the following output in the java script console when clicking one of the social media icons:

Error: Permission denied to access property "postMessage" en:132:4
Error: Permission denied to access property "postMessage" widgets.js:1:18086
"Invalid App Id: Must be a number or numeric string representing the application id." all.js:64:238
"FB.getLoginStatus() called before calling FB.init()." all.js:64:238
TypeError: a is undefined plusone.js:43:791
Diese Website verwendet ein SHA-1-Zertifikat; es wird empfohlen, Zertifikate mit Signaturalgorithmen zu verwenden, die stärkere Hashfunktionen verwenden als SHA-1.[Weitere Informationen] badge
Using //@ to indicate sourceURL pragmas is deprecated. Use //# instead rs=AGLTcCMcKSJXdPyjlQBxpi--mrC8VUXzXQ:90:0
Using //@ to indicate sourceURL pragmas is deprecated. Use //# instead rs=AGLTcCMcKSJXdPyjlQBxpi--mrC8VUXzXQ:273:0
getAttributeNode() sollte nicht mehr verwendet werden. Verwenden Sie stattdessen getAttribute(). rs=AGLTcCMcKSJXdPyjlQBxpi--mrC8VUXzXQ line 6 > eval:35:0
Diese Website verwendet ein SHA-1-Zertifikat; es wird empfohlen, Zertifikate mit Signaturalgorithmen zu verwenden, die stärkere Hashfunktionen verwenden als SHA-1.[Weitere Informationen] like.php
TypeError: a is undefined plusone.js:43:791

[greiner]

This issue appears to be the same as ​the one reported at Bugzilla earlier this year. The share.adblockplus.org page is running in an unprivileged window and wants to communicate with its parent frame which is a privileged window by using window.parent.postMessage.

The suggested approach on that thread is to use ​WebChannel instead which requires changes on both ends of the line.

[greiner]

Simplified the ticket description a bit.

[trev]

It looks like WebChannel will only work in Firefox, not in SeaMonkey or Firefox Mobile. That should to be tested because it won't work for us as solution then.

[greiner]

This behavior appears to be a regression introduced in Firefox 38. I filed ​bug 1177795 at Bugzilla.

[greiner]

​https://hg.adblockplus.org/adblockplusui/rev/3a06b955c3f7
​https://hg.adblockplus.org/share.adblockplus.org/rev/77d276f69bfe

[trev]

Removed milestone - this won't get into release automatically, a dependency update is needed.