Opened on 06/25/2015 at 12:49:55 PM
Closed on 06/25/2015 at 03:56:49 PM
#2722 closed change (fixed)
Don't report persistent errors with external APIs more often than once a day
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | trev, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
We rely on browser vendor's update APIs to retrieve the current browser versions to be listed on https://adblockplus.org/en/requirements. But occasionally these requests fail.
We already implemented logic to fallback to the last successfully retrieved list of browser versions then. And we also don't log warnings for failures that occur for less than two hours in a row, anymore. But persistent issues, we usually cannot do anything about, still spam the cron log every 15 minutes.
What to change
Don't log warnings for persistent failures more often than once a day.
Attachments (0)
Change History (2)
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/web.adblockplus.org/rev/065d63787cf6