ABP Chrome does not display received notifications

[Ross]

Environment

ABP 1.9.0.1458
Chrome 43.0.2357.130 / Windows 8.1 x64

How to reproduce

1. Set up a valid notification on the server.
2. Un-install/Re-install the ABP for Chrome development build.
3. Restart Chrome.
4. Wait one minute for notifications to be requested.
5. Confirm the response contained a notification.
6. Observe ABP for Chrome never displays the notification.

Observed behaviour

The notification is never displayed.

Expected behaviour

The notification should be displayed.

[greiner]

Cannot reproduce this issue with the following setups:

Adblock Plus 1.9.0.1458
Chrome 43.0.2357.130 (64-bit)
Ubuntu 14.04

Adblock Plus 1.9.0.1458
Chrome 43.0.2357.130 m
Windows 8.1

notification.json:

{
  "notifications": [
    {
      "id": 1,
      "type": "information",
      "message": "This is a test!"
    }
  ],
  "version": "201506291240"
}

Note that "information"-type messages don't trigger a desktop notification to be shown. They only cause the toolbar icon to animate and the message to be shown within in the icon popup.

[Ross]

Thank you for checking. Works as described.

For my future reference:

• "information" = Animate icon. Displayed in popup.
• "critical" = Displayed as Chrome notification.

ABP 1.9.0.1458
Chrome 43.0.2357.130 / Windows 8. x64

[greiner]

Replying to Ross:

For my future reference:

• "information" = Animate icon. Displayed in popup.
• "critical" = Displayed as Chrome notification.

Actually, it's a bit more complicated and unfortunately, we don't have a proper documentation for that yet so here's the gist of it:

• critical
  • animate icon with "!"
  • show in popup
  • show desktop notification
• information
  • animate icon with "?"
  • show in popup
• question
  • show desktop notification

Note that a desktop notification can be all sorts of things, depending on the capabilities of the platform (e.g. Chrome notification, window.confirm(), XUL panel).

[Ross]

Useful thank you! Will try to include it in the testing notes.