Using runserver cms returns 500 status code for /subscriptions

[greiner]

Environment

Ubuntu 14.04

How to reproduce

1. Clone cms and web.adblockplus.org repositories
2. Run pyinstaller runserver.spec in cms directory (as described in the cms README)
3. Run <path-to-cms>/dist/runserver in web.adblockplus.org directory
4. Navigate to http://localhost:5000/en/subscriptions in your browser

Observed behaviour

Error page shown:

500 Internal Server Error
An error occurred while processing the request for /en/subscriptions:
No module named sitescripts.subscriptions

Expected behaviour

The get_subscriptions filter in web.adblockplus.org should handle the sitescripts.subscriptions module being missing, not raising an exception, but simply returning an empty list.

[sebastian]

I'm undecided whether we should bundle the sitescripts.subscriptions module with the exectuable. Or whether we should rather make the get_subscriptions filter return an empty list (and log a warning) if that module doesn't exist.

[kzar]

@Sebastian The latter in my opinion. If you're just trying to test a completely unrelated change it's kind of annoying having to get sitescripts set up as well.

[sebastian]

Yeah, that is also what I tend to. Bundling arbitrary modules with the general purpose development server doesn't seem to be right. And as you pointed out simply bundling that module wouldn't suffice in this case anyway.

[juliandoucette]

​https://hg.adblockplus.org/web.adblockplus.org/rev/6e98138c8498