Opened on 07/23/2015 at 08:03:57 PM
Closed on 07/31/2015 at 05:02:05 PM
#2816 closed defect (fixed)
EHH button in inspector tool does not work - FF developer edition 41.0a2 (2015-07-23)
| Reported by: | mapx | Assignee: | trev |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Element-Hiding-Helper-1.3.3 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | trev, greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29322778/ |
||
Description (last modified by trev)
Environment
windows 7
FF developer edition 41.0a2 (2015-07-23)
ABP 2.6.9.3966
EHH 1.3.2.495
How to reproduce
-go to google.co.uk
-right click "images" top right
-in the inspector window on the highlighted row click the ABP icon (left ABP icon in the inspector panel)
-the "compose element hiding rule" window will be opened but empty
Background
The Inspector panel was made E10S-aware. It no longer accesses the elements directly but rather through wrappers talking to the remote process. These wrappers have an API which is similar to DOM but not quite identical.
Attachments (0)
Change History (5)
comment:2 Changed on 07/28/2015 at 08:56:42 AM by trev
- Owner set to trev
- Ready set
comment:3 Changed on 07/28/2015 at 09:54:39 AM by trev
comment:4 Changed on 07/30/2015 at 01:13:57 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 07/31/2015 at 05:02:05 PM by trev
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Error message is: "TypeError: element is null"