Opened on 08/07/2015 at 09:57:54 PM
Closed on 01/20/2016 at 01:17:04 PM
#2875 closed defect (worksforme)
ModPagespeed defer_javascript issue with active ABP
Reported by: | Rotate | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Platform | Keywords: | |
Cc: | sebastian, trev, mapx, arthur, kzar | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by mapx)
Environment
Win 7, Chrome latest, Safari latest.
Observed behaviour
When I enable "ModPagespeedEnableFilters defer_javascript ", the page is going really fast.
I win at the Page Speed Insights Score added +30 points .
Unfortunately, there is then a few problems :
Chrome with active Adblocker plugin didn't render the page completely. It hangs in process ("waiting for Adblocker Plus" in the status bar.
In FireFox the problem doesn't occur with active AdBlocker.
With deactivated Adblocker everything is fine in Chrome and FF.
In Safari on iOS (eg. iPhone) the page will depend also.
Expected behaviour
Please take a look at this article-site: http://www.dance-charts.de/201508075831/felix-jaehn-feat-polina-book-of-love
Soundcloud-player, disqus and several other elements won't be loaded with active AdBlocker Plus in Chrome.
Attachments (0)
Change History (20)
comment:1 Changed on 08/08/2015 at 08:21:11 AM by mapx
- Cc sebastian trev mapx arthur added
- Component changed from Unknown to Platform
comment:2 Changed on 08/08/2015 at 08:23:04 AM by mapx
comment:3 Changed on 08/08/2015 at 08:23:23 AM by Rotate
At the moment "ModPagespeed defer_javascript" is deactivated at the article-site (see link above).
comment:4 follow-up: ↓ 5 Changed on 08/08/2015 at 08:24:45 AM by mapx
probably you should prepare a test page where ModPagespeed defer_javascript is always enabled
comment:5 in reply to: ↑ 4 Changed on 08/08/2015 at 08:44:35 AM by Rotate
Replying to mapx:
probably you should prepare a test page where ModPagespeed defer_javascript is always enabled
Coming soon...
comment:7 Changed on 08/08/2015 at 11:13:00 AM by Rotate
Please check this test-page:
comment:8 Changed on 08/08/2015 at 11:22:57 AM by mapx
the test page is ok in firefox
it seems to be ok in chrome only adding this exception
@@||ad.yieldlab.net$domain=dance-charts.de
comment:9 Changed on 08/10/2015 at 09:22:08 AM by arthur
That should do it: https://hg.adblockplus.org/easylistgermany/rev/c848369d2bc0
comment:10 Changed on 08/11/2015 at 01:05:56 PM by Rotate
Unfortunately not. No change with the updated whitelist. Just checked.
The demo-page is not active at the moment. Too much bugs. I can reacitvate if you want for a certain time.
comment:11 Changed on 08/11/2015 at 01:32:11 PM by arthur
Yes, please re-activate it.
comment:12 Changed on 08/11/2015 at 05:20:14 PM by Rotate
It's active now on this site only: www.dance-charts.de/tippspiel
comment:13 Changed on 08/12/2015 at 03:40:40 PM by Rotate
Any new insights?
comment:14 Changed on 10/20/2015 at 11:19:40 AM by kzar
- Cc kzar added
Hi Rotate, please can you update the ticket description with a concrete list of steps I should take to reproduce, with expected vs observed outcomes? I can't reproduce this as described but I don't want to reject the issue before I properly understand.
comment:15 Changed on 11/16/2015 at 10:03:53 AM by kzar
- Resolution set to worksforme
- Status changed from new to closed
Closing this for now as it has been about a month since I asked for help reproducing the issue.
comment:16 Changed on 12/31/2015 at 05:50:22 AM by Rotate
- Resolution worksforme deleted
- Status changed from closed to reopened
okay. Next try. Still the same problem:
Website doesn't render completly / breaks with active ABP in Chrome. Without there is no problem.
In Firefox it works fine with active ABP.
Examples:
www.dance-charts.de
www.dance-charts.de/tippspiel
www.dance-charts.de/201512306543/guns-n-roses-comeback-beim-coachella-festival-2016
Menu-navigation drop downs doesn't work or some elements in the right sidebar breaks.
"ModPagespeed defer_javascript" is active now. We should solve this problem.
comment:17 Changed on 12/31/2015 at 01:16:20 PM by mapx
@@||dance-charts.de^$genericblock ||tpc.googlesyndication.com/pagead/imgad$domain=dance-charts.de ||adclick.g.doubleclick.net^$popup,domain=dance-charts.de ||dance-charts.de/images/banners/*$domain=dance-charts.de dance-charts.de##.advert
comment:18 Changed on 12/31/2015 at 06:12:42 PM by Rotate
Thanks. Seems to be working here.
comment:19 Changed on 01/04/2016 at 04:24:36 PM by arthur
I couldn't encounter any issues on the provided links.
comment:20 Changed on 01/20/2016 at 01:17:04 PM by sebastian
- Resolution set to worksforme
- Status changed from reopened to closed
As far as I understand, ModPageSpeed is an nginx/Apache module that manipulates your web content to optimize performance. There is a setting defer_javascript which if enabled, causes the HTML to be rewritten in a way that scripts are loaded after the page finished loading.
According to OP, on their website, some third-party widgets (e.g. SoundClous, Disqus) doesn't load if using Adblock Plus and if defer_javascript is enabled. With the links provided above I couldn't reproduce that, however.
Since, others apparently couldn't reproduce the issue either with the information provided, I am closing this issue now. Feel free to reopen if it happens again, but provide exact steps to reproduce, the exact version of Chrome and Adblock Plus you are using, and your Adblock Plus settings.
see in forum https://adblockplus.org/forum/viewtopic.php?f=2&t=29832