Opened on 08/10/2015 at 11:27:28 AM
Closed on 08/11/2015 at 12:41:43 PM
Last modified on 08/11/2015 at 12:42:48 PM
#2878 closed defect (fixed)
Element Hiding Helper is stuck in a bad state after a tab crash
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Element-Hiding-Helper-1.3.3 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | e10s |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Adblock Plus 2.6.10.3969, Element Hiding Helper 1.3.2.497, Firefox 42.0a1 (2015-08-09 nightly), Mac OS X 10.10.
How to reproduce
- Go to any website.
- Click ABP icon and choose "Select an element to hide".
- Kill the Nightly Web Content process via whatever tools your OS provides.
- Restore the tabs and repeat step 2.
Observed behaviour
"Error: cannot use a CPOW whose process is gone" messages in Browser Console coming from https://hg.adblockplus.org/elemhidehelper/file/1424869523d1/lib/aardvark.js#l396 and https://hg.adblockplus.org/elemhidehelper/file/1424869523d1/chrome/content/actor.jsm#l85. Even after restoring the crashed tabs Element Hiding Helper remains in the "selecting" state and cannot abort.
Expected behaviour
Element Hiding Helper should allow selecting in the restored tabs.
Attachments (0)
Change History (5)
comment:1 Changed on 08/10/2015 at 11:40:17 AM by trev
- Owner set to trev
comment:2 Changed on 08/10/2015 at 11:45:57 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/10/2015 at 12:53:55 PM by trev
- Keywords e10s added
comment:4 Changed on 08/11/2015 at 12:41:43 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/11/2015 at 12:42:48 PM by trev
- Milestone set to Element-Hiding-Helper-1.3.3
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/elemhidehelper/rev/9631b272a434