Opened on 04/09/2014 at 08:48:48 AM
Closed on 07/08/2014 at 12:24:42 PM
Last modified on 05/20/2015 at 02:22:39 PM
#290 closed defect (fixed)
[seamonkey] blockable items list persists tab changes
| Reported by: | philll | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6.4-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Seamonkey 2.25
ABP 2.5.1
How to reproduce
- Go to a website
- Open blockable items (Ctrl+Shift+V)
- Open a new tab (Ctrl+t) and go to another website
- Left-click the tab with the first website
Observed behaviour
The blockable items list still shows the items from the second tab's website.
Expected behaviour
The blockable items list should show the items from the first tab's website.
Attachments (0)
Change History (6)
comment:1 Changed on 07/06/2014 at 08:55:34 AM by saroyanm
- Owner set to saroyanm
- Platform set to Unknown
comment:2 Changed on 07/06/2014 at 09:59:02 AM by saroyanm
comment:3 Changed on 07/06/2014 at 01:01:33 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 07/08/2014 at 12:24:42 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Wladimir filed a bug in Seamonkey:
https://bugzilla.mozilla.org/show_bug.cgi?id=1035171
Until this is fixed we will override ignoreSameDoc parameter to false for Seamonkey.
Revision:
https://hg.adblockplus.org/adblockplus/rev/5cb1f27ffff2
comment:5 Changed on 07/15/2014 at 05:02:30 PM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Milestone set to Adblock-Plus-for-Firefox-next
- Platform changed from Unknown to Firefox/Firefox Mobile
comment:6 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Note: See
TracTickets for help on using
tickets.
The issue looks caused by onLocationChange method's aFlags attribute.
While in Firefox it's implemented as optional attribute:
http://mxr.mozilla.org/mozilla-central/source/uriloader/base/nsIWebProgressListener.idl#344
In Seamonkey the implementation for the attribute is missing:
http://mxr.mozilla.org/seamonkey/source/uriloader/base/nsIWebProgressListener.idl#322