Opened on 08/17/2015 at 02:18:25 AM
Closed on 08/17/2015 at 11:12:20 PM
#2912 closed change (fixed)
New default for $nginx::worker_processes
Reported by: | matze | Assignee: | matze |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | fred | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29323735 |
Description
The number of $nginx::worker_processes should default to the node's $::processorcount (a Facter variable), instead of hard-coding it based on the current number of CPUs. See also #2888.
Attachments (0)
Change History (3)
comment:1 Changed on 08/17/2015 at 02:41:47 AM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 08/17/2015 at 11:12:20 PM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/infrastructure/rev/df0a3aeff7fa
https://hg.adblockplus.org/infrastructure/rev/dfd0099bb921
https://hg.adblockplus.org/infrastructure/rev/72b7e10d60f6
https://hg.adblockplus.org/infrastructure/rev/bf9aa319d00c
https://hg.adblockplus.org/infrastructure/rev/89ca37c33291
https://hg.adblockplus.org/infrastructure/rev/dcc62c5491ab
While the initial change-set is quite trivial, the work won't be done with this one alone:
Obvously a lot of our modules define the number of $nginx::worker_processes for their individual application. This does not make much sense anymore, especially with the change-set from both this ticket here as well as the one from #2888.
In fact it should be enough to just remove all of the occurrences listed above. One can use the Hiera option nginx::worker_processes instead. For now that won't be necessary though: All of the above numbers "accidentally" reflect the number of CPUs in their respective production setup. Well, this is of course no accident, but a tribute to the quirks of the former approach.
Note, however, that the removal should be split up in multiple commits (except for filterserver and notificationserver, those may be put together). All of these can use this very ticket here as reference number though.