Opened on 08/19/2015 at 02:21:38 PM
Closed on 08/22/2015 at 09:26:37 PM
#2928 closed change (fixed)
Add new icon for touch devices on adblockplus.org and acceptableads.org
| Reported by: | sven | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | saroyanm, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29324393/ |
||
Description (last modified by sven)
Attachments (2)
Change History (18)
Changed on 08/19/2015 at 02:26:06 PM by sven
Changed on 08/19/2015 at 02:26:12 PM by sven
comment:2 Changed on 08/19/2015 at 02:31:48 PM by saroyanm
comment:3 Changed on 08/19/2015 at 02:32:54 PM by saroyanm
- Summary changed from sssssd to Update favicon on adblockplus.org and acceptableads.org
comment:4 Changed on 08/19/2015 at 02:36:50 PM by sven
Because it's a blocker for the Adblock Browser release.
comment:5 Changed on 08/19/2015 at 02:39:23 PM by saroyanm
I don't think it's blocker, as far as I know it's just about ABP.org and AA.org bookmarks doesn't look nice.
Do we have that bookmarks there by default ?
comment:6 Changed on 08/19/2015 at 02:58:42 PM by sven
@saroyanm it's a blocker, because these two are shown as the default bookmarks on the dashboard.
comment:8 Changed on 08/19/2015 at 03:44:12 PM by saroyanm
- Owner set to saroyanm
comment:9 Changed on 08/19/2015 at 04:30:04 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:10 Changed on 08/19/2015 at 05:11:43 PM by saroyanm
Icon for adblockplus.org added:
https://hg.adblockplus.org/web.adblockplus.org/rev/c7c77df35f06
comment:11 Changed on 08/20/2015 at 12:15:29 PM by saroyanm
- Component changed from Adblock-Browser-for-iOS to Websites
comment:12 Changed on 08/20/2015 at 02:57:07 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Large Icon for touche devices added to acceptableads.com:
https://hg.adblockplus.org/web.acceptableads.org/rev/7a7c488cdaef
favicon.ico should be uploaded by #2933
comment:13 Changed on 08/20/2015 at 02:58:33 PM by saroyanm
- Summary changed from Update favicon on adblockplus.org and acceptableads.org to Add new icon for touch devices on adblockplus.org and acceptableads.org
comment:14 Changed on 08/21/2015 at 09:16:47 AM by saroyanm
- Cc greiner added
- Resolution fixed deleted
- Status changed from closed to reopened
The ticket is reopened while precomposed suffix for apple-touch-icon is not supported by Kitt, make sense to remove that suffix.
comment:15 Changed on 08/21/2015 at 09:18:17 AM by saroyanm
- Review URL(s) modified (diff)
comment:16 Changed on 08/22/2015 at 09:26:37 PM by saroyanm
- Resolution set to fixed
- Status changed from reopened to closed
Why the priority is P1 ?