Opened on 08/20/2015 at 07:25:40 AM
Closed on 08/31/2015 at 10:30:11 AM
#2932 closed change (fixed)
Adblock Browser specific look and feel
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-beta-1.0.0.2015083121 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29325144/ |
||
Description (last modified by fhd)
Background
Adblock Browser for Android currently looks just like Firefox for Android. It is a different product and should have it's own look, closer to Adblock Browser for iOS. We didn't manage to change this for the beta release, but we definitely want to change it before the stable release.
What to change
Change the colours and dimensions of the following UI elements, as in the respective style guides:
Attachments (4)
Change History (15)
comment:1 Changed on 08/20/2015 at 07:26:56 AM by fhd
- Owner set to rjeschke
comment:2 Changed on 08/20/2015 at 12:28:24 PM by greiner
- Cc greiner added
comment:3 Changed on 08/20/2015 at 05:51:35 PM by fhd
- Milestone set to Adblock-Browser-for-Android-next
comment:5 Changed on 08/27/2015 at 10:13:30 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 08/28/2015 at 07:21:28 AM by fhd
Pushed:
- https://bitbucket.org/adblockplus/adblockbrowser/commits/6a1784d0844429c2929653822cd6a56912406566
- https://bitbucket.org/adblockplus/adblockbrowser/commits/0e753a0644e3276760aed17f8af438bf078d497e
Since René is unfortunately unavailable and nobody else can reasonably jump in, the latter hasn't been reviewed yet.
The issue also still needs to be updated.
comment:8 Changed on 08/28/2015 at 09:26:11 AM by fhd
- Owner changed from rjeschke to fhd
comment:9 Changed on 08/28/2015 at 10:59:58 AM by fhd
- Review URL(s) modified (diff)
Another patch, pushed that one unreviewed for the same reason:
https://bitbucket.org/adblockplus/adblockbrowser/commits/07e8d24090ca1951e6fdb5dcb759d002918835f8
Changed on 08/28/2015 at 10:46:42 PM by fhd
Changed on 08/28/2015 at 10:47:02 PM by fhd
Changed on 08/28/2015 at 10:47:14 PM by fhd
Changed on 08/28/2015 at 10:47:22 PM by fhd
comment:10 Changed on 08/28/2015 at 11:07:43 PM by fhd
- Description modified (diff)
- Ready set
comment:11 Changed on 08/30/2015 at 12:12:13 PM by fhd
- Review URL(s) modified (diff)
And another patch, pushed pre-review as well:
https://bitbucket.org/adblockplus/adblockbrowser/commits/0810740b9b4e9ab5f60e78f3db94b33c3ae31f28
comment:12 Changed on 08/31/2015 at 10:30:11 AM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
Assigning to René since I know he's working on it. Once you guys have figured out how exactly it should look, please complete the What to change part.