Opened on 08/20/2015 at 03:31:34 PM

Closed on 08/24/2015 at 10:46:15 AM

#2935 closed change (fixed)

[cms] Give get_string global template function sensible default for page paramter

Reported by: kzar Assignee: kzar
Priority: Unknown Milestone:
Module: Sitescripts Keywords: cms
Cc: saroyanm, trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29324494/

Description

Background

In our CMS there is a get_string global template function defined that can be used from Jinja2 templates. It takes two arguments, a string name and a page name. Currently neither have default values.

What to change

It is quite comment to want to obtain strings for the current page. Therefore the page name parameter for the get_string global template function should have a default value of the current page.

Attachments (0)

Change History (2)

comment:1 Changed on 08/20/2015 at 08:53:33 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 08/24/2015 at 10:46:15 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/cms/rev/b03a74b3276e

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.