Opened on 08/30/2015 at 12:53:42 PM

Closed on 08/31/2015 at 10:29:38 AM

#2961 closed change (fixed)

[build] Specify distribution mode in addition to the build mode

Reported by: fhd Assignee: fhd
Priority: P3 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015083121
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29325378/

Description (last modified by fhd)

Background

We currently only have a build mode: devbuild or release. Based on the build mode, we also make a decision about whether the updater should be enabled. This is not flexible enough, we need a release build with the updater disabled.

What to change

Add an additional parameter to build.py that can either be standalone or store. The build should then use a mozconfig with or without the updater, respectively.

Attachments (0)

Change History (6)

comment:1 Changed on 08/30/2015 at 12:54:12 PM by fhd

  • Owner set to fhd

comment:2 Changed on 08/31/2015 at 06:19:53 AM by fhd

  • Description modified (diff)
  • Summary changed from [build] Specify whether the updater should be enabled in addition to the build mode to [build] Specify distribution mode in addition to the build mode

comment:3 Changed on 08/31/2015 at 06:21:12 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/31/2015 at 06:45:16 AM by fhd

  • Milestone set to Adblock-Browser-for-Android-next-devbuild

comment:5 Changed on 08/31/2015 at 08:31:48 AM by fhd

comment:6 Changed on 08/31/2015 at 10:29:38 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
 
Note: See TracTickets for help on using tickets.