Opened on 09/01/2015 at 11:16:39 AM

Closed on 09/01/2015 at 11:37:14 AM

Last modified on 09/01/2015 at 01:58:03 PM

#2968 closed change (fixed)

Implement multi inheritance for metadata files

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29325410

Description

Background

To avoid duplication in forks of Adblock Plus for multiple platforms we need a way to inherit from multiple metadata files. So a "fork" can derive from from metadata.chrome or metadata.safari as well as from their own metadata mixin for example.

What to change

A metadatra file that uses following option, should inherit all options from both metadata.chrome and metadata.custom, while similar to multi inheritance in Python, options from the former file should override options from the latter in case of a conflict.

[default]
inherit = metadata.chrome metadata.custom

Attachments (0)

Change History (3)

comment:1 Changed on 09/01/2015 at 11:18:31 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/01/2015 at 11:37:14 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/buildtools/rev/825954e0ec38

comment:3 Changed on 09/01/2015 at 01:58:03 PM by sebastian

  • Cc sebastian added

302 is implemented inconsistently across browsers, and seems to be superseded by 303 and 307 in HTTP 1.1. Also see the discussion in that ​review.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.