Opened on 09/02/2015 at 12:21:38 PM

Closed on 09/02/2015 at 02:14:07 PM

#2977 closed change (fixed)

Don't add translations that are identical to the default locale's strings

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015090419
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29325540/

Description (last modified by fhd)

Background

translations.py get currently downloads all translations from Crowdin, including those where not a single string has been translated. Those end up being identical to the default locale, and since we fall back to en-US anyway, they're just redundant.

What to change

Make translations.py get not add translations that are identical to the default locale's strings.

Attachments (0)

Change History (5)

comment:1 Changed on 09/02/2015 at 12:25:13 PM by fhd

  • Owner set to fhd
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 09/02/2015 at 12:25:56 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/02/2015 at 12:37:13 PM by fhd

  • Description modified (diff)
  • Summary changed from Don't add translations that are identical to the source texts to Don't add translations that are identical to the default locale texts

comment:4 Changed on 09/02/2015 at 12:37:38 PM by fhd

  • Summary changed from Don't add translations that are identical to the default locale texts to Don't add translations that are identical to the default locale's strings

comment:5 Changed on 09/02/2015 at 02:14:07 PM by fhd

  • Milestone set to Adblock-Browser-for-Android-beta-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/90be39a674b093c354e5edb035056654c387df10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.