Opened on 09/07/2015 at 05:16:27 PM
Closed on 09/08/2015 at 09:33:17 AM
#3002 closed change (fixed)
Write and use getDevEnvPath function for determining the devenv build path
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
When building the developer environment or devenv version of the extension the output path is not configurable. We now need the ability to configure it. If we separate the logic for determining the path into its own function we can then monkey-patch that function when needed.
What to change
- Add a function getDevEnvPath to buildtools/packager.py that returns the output devenv path as is currently used.
- Use that function from the createDevEnv function in buildtools/build.py instead of having the value of devenv_dir hard-coded.
Attachments (0)
Change History (3)
comment:1 Changed on 09/07/2015 at 05:22:58 PM by kzar
- Ready set
comment:2 Changed on 09/07/2015 at 05:35:43 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/08/2015 at 09:33:17 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/buildtools/rev/c35425cca589