Opened on 09/08/2015 at 11:27:14 AM
Closed on 09/08/2015 at 04:32:20 PM
Last modified on 09/08/2015 at 04:32:36 PM
#3013 closed change (fixed)
[adblockplus.org] Replace /en/adblock-browser with a redirect to adblockbrowser.org
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | #3015 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29326094/ |
||
Description
Background
Now that Adblock Browser has been released, we have no more use for /en/adblock-browser, we should just redirect to adblockbrowser.org.
What to change
Redirect users that visit /en/adblock-browser to https://adblockbrowser.org. At the same time, we should get rid of now unused code.
Attachments (0)
Change History (10)
comment:1 Changed on 09/08/2015 at 11:28:36 AM by fhd
- Owner set to fhd
comment:2 Changed on 09/08/2015 at 11:29:39 AM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/08/2015 at 12:16:42 PM by sebastian
- Cc sebastian added
comment:4 Changed on 09/08/2015 at 01:35:43 PM by sebastian
- Blocking 3015 added
comment:6 Changed on 09/08/2015 at 03:14:31 PM by fhd
Pushed and deployed the infrastructure change pre-review due to time constraints:
https://hg.adblockplus.org/infrastructure/rev/d488341c30d0
Also pushed: https://hg.adblockplus.org/web.adblockplus.org/rev/a8cb7e9526ee
comment:7 Changed on 09/08/2015 at 03:44:47 PM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 09/08/2015 at 03:50:35 PM by sebastian
- Resolution fixed deleted
- Status changed from closed to reopened
Again, what is with the link on the homepage? I think we should directly link to https://adblockbrowser.org/ there without a redirect.
comment:9 Changed on 09/08/2015 at 04:28:37 PM by fhd
Which link do you mean? On the landing page I only see one pointing to adblockbrowser.org, no redirects.
comment:10 Changed on 09/08/2015 at 04:32:20 PM by sebastian
- Resolution set to fixed
- Status changed from reopened to closed
Alright. The page was delivered from the cache. Looks fine, when force reloading the page.
Please also make the link on https://adblockplus.org/ link directly to https://adblockbrowser.org/.
Moreover, I think we probably should do a proper permanent redirect on the server-side, rather than using the http-equiv hack. I didn't mind using that hack on the job page, as SEO doesn't matter to much there, and we are going to remove it anyway, once we take down the job ad. But I think it would be worth doing it properly for the Adblock Browser landing page.