Opened on 09/08/2015 at 01:46:15 PM
Closed on 09/08/2015 at 02:08:43 PM
#3017 closed change (fixed)
Improve file mapping precedence with inherited metadata files
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
When inheriting metadata files you can overwrite the value of options that have been set by the inherited file. You should also be able to ovewrite file mapping paths specified in metadata files in the same way. Unfortunately though as it stands this doesn't work, the inherited file's value takes precedence.
What to change
Modify the logic inside buildtools/packager.py so that the path specified in the "parent" metadata file for a mapping takes precedence.
Attachments (0)
Change History (3)
comment:1 Changed on 09/08/2015 at 01:50:27 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/08/2015 at 01:57:42 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 09/08/2015 at 02:08:43 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
(I've tested this change and it has no effect on the build output for the Chrome, Safari, Opera or Firefox extensions.)