Opened on 09/09/2015 at 09:13:36 AM
Closed on 09/11/2015 at 01:17:39 PM
Last modified on 09/24/2015 at 02:57:35 PM
#3032 closed defect (fixed)
Whitelisted Google AdSense for Search ads not showing up
Reported by: | arthur | Assignee: | |
---|---|---|---|
Priority: | P1 | Milestone: | Adblock-Browser-for-iOS-1.1.0 |
Module: | Adblock-Browser-for-iOS | Keywords: | |
Cc: | jand, pavelz, vojtab | Blocked By: | |
Blocking: | Platform: | Adblock Browser for iOS | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
- iPhone 6 Plus with iOS 9.0 (13A4325c)
- Adblock Browser v1.0.0 (core 1.2.18)
- EasyList
- Acceptable Ads on
How to reproduce
- Open Adblock browser
- Go to http://www.gutefrage.net/
- Tap on the hamburger menu on the top left
- Search for "iphone"
Observed behaviour
Google AdSense for Search ads at the top of the search results don't display properly. The actual links are missing.
Expected behaviour
Google AdSense for Search ads at the top of the search results should be visible properly with links.
My assumptions
It seems Adblock Browser doesn't seem to respect the $document filter option. This exception rule in the Acceptable Ads whitelist @@||google.com/cse?$subdocument,document,domain=gutefrage.net should make sure that everything in the iframe used for the ads is being whitelisted and no element hiding filters are appplied. However, the latter seems to be the case. If I disable @@||google.com/cse?$subdocument,document,domain=gutefrage.net in Firefox and add @@||google.com/cse?$subdocument,domain=gutefrage.net instead, the ads look the same in Firefox as in Adblock Browser on the iPhone. Removing the $document option from that exeption rule causes element hiding to be applied in the iframe. In this case ##a[href^="http://www.google.com/aclk?"] is being applied which hides the ad links in it.
Attachments (2)
Change History (5)
Changed on 09/09/2015 at 09:13:52 AM by arthur
Changed on 09/09/2015 at 09:13:58 AM by arthur
comment:1 Changed on 09/11/2015 at 01:17:39 PM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed on 09/11/2015 at 01:35:40 PM by jand
comment:3 Changed on 09/24/2015 at 02:57:35 PM by fhd
- Milestone set to Adblock-Browser-for-iOS-1.1.0
Link to pivotaltracker story:
https://www.pivotaltracker.com/story/show/103192014