Opened on 09/09/2015 at 09:26:43 AM
Closed on 08/11/2016 at 10:06:16 AM
Last modified on 03/06/2017 at 03:16:03 PM
#3034 closed defect (fixed)
Google AdSense for Search ads not showing up with Acceptable Ads enabled
| Reported by: | arthur | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-for-iOS-next |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | AcceptableAds |
| Cc: | sebastian, kzar, mario | Blocked By: | |
| Blocking: | Platform: | iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
- iPhone 6 Plus with iOS 9.0 (13A4325c)
- Adblock Plus for Safari iOS Version 1.0 (1)
- Acceptable Ads enabled
How to reproduce
- Open Adblock browser
- Go to http://www.gutefrage.net/
- Tap on the hamburger menu on the top left
- Search for "iphone"
Observed behaviour
Google AdSense for Search ads at the top of the search results don't display properly. The actual links are missing.
Expected behaviour
Google AdSense for Search ads at the top of the search results should be visible properly with links.
Attachments (0)
Change History (15)
comment:1 Changed on 09/10/2015 at 08:38:41 AM by fhd
- Priority changed from Unknown to P1
comment:2 Changed on 09/10/2015 at 08:41:51 AM by fhd
- Owner set to fhd
- Ready set
comment:3 Changed on 09/12/2015 at 08:15:46 AM by fhd
- Owner fhd deleted
Unassigning myself for now - I'm not actually working on this right now, even though it's high on my list. Anyone who wants to do it though, go ahead.
comment:4 Changed on 09/24/2015 at 03:26:14 PM by philll
- Platform changed from Unknown / Cross platform to iOS
Added newly available platform value.
comment:5 Changed on 08/08/2016 at 12:58:06 PM by mario
- Keywords AcceptableAds added
comment:6 Changed on 08/09/2016 at 05:46:02 PM by kzar
- Cc sebastian kzar mario added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 08/09/2016 at 05:46:14 PM by kzar
- Owner set to kzar
comment:8 Changed on 08/09/2016 at 05:53:44 PM by kzar
(This appears to no longer be a problem when using a new content blocking list that was generated from an up to date easylist.txt, exceptionrules.txt and abp2blocklist. At least not for the given example site gutefrage.net.)
comment:9 follow-up: ↓ 10 Changed on 08/09/2016 at 06:35:36 PM by kzar
Arthur could you clarify, are these "Google AdSense for Search" ads supposed to be whitelisted for all domains, just gutefrage.net or a list of domains?
comment:10 in reply to: ↑ 9 Changed on 08/10/2016 at 10:27:17 AM by arthur
Replying to kzar:
Arthur could you clarify, are these "Google AdSense for Search" ads supposed to be whitelisted for all domains, just gutefrage.net or a list of domains?
In this case it's specifically whitelisted for gutefrage.net but I could provide some other examples if you like.
comment:11 Changed on 08/10/2016 at 10:51:31 AM by kzar
So we whitelist these adverts for only certain domains, not for all websites? In that case, yes please, could you give me the entire list so that I can whitelist them all?
comment:12 Changed on 08/11/2016 at 09:18:02 AM by arthur
It seems these search ads have been whitelisted globally recently. So there is no need to whitelist specific sites.
comment:13 Changed on 08/11/2016 at 10:04:01 AM by abpbot
A commit referencing this issue has landed:
Issue 3034 - Fix Google's "AdSense for Search" ads
comment:14 Changed on 08/11/2016 at 10:06:16 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:15 Changed on 03/06/2017 at 03:16:03 PM by mario
- Milestone set to Adblock-Plus-for-iOS-next
Batch-adjusted milestone for upcoming release of ABP for iOS.
Apparently not working on any site - P1.