Opened on 09/10/2015 at 07:09:00 AM

Closed on 09/24/2015 at 08:54:07 PM

#3048 closed defect (fixed)

Clients don't stay in test group if notification is inactive

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: sporz, kirill Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29327106/

Description

Environment

sitescripts revision 9286a9834488.

How to reproduce

  1. Set up a notification with at least one variant, and in addition either the start parameter set to the future, the end parameter set to the past, or the inactive parameter set to True.
  2. Make a notification request with lastVersion set to 197001010000-a/0, e.g. `​https://notification.adblockplus.org/.

Observed behaviour

version doesn't end in -a/0.

Expected behaviour

In the response, version should end in -a/0.

Attachments (0)

Change History (5)

comment:1 Changed on 09/10/2015 at 07:17:26 AM by fhd

  • Owner set to fhd

comment:2 Changed on 09/10/2015 at 09:08:46 AM by Kirill

  • Cc sporz kirill added

comment:3 Changed on 09/10/2015 at 11:39:09 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 09/24/2015 at 05:59:22 PM by Ross

  • Verified working set

The variations described are all working (inactive=true, start in future, end in past).

issue-3048.patch
infrastructure-git / upstream / 5a8350483c0d0d3aadf7432bbdf34d92a7190582

comment:5 Changed on 09/24/2015 at 08:54:07 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/sitescripts/rev/31c63c8eadf2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.