Opened on 09/10/2015 at 12:34:36 PM
Closed on 09/10/2015 at 02:10:29 PM
Last modified on 09/17/2015 at 04:28:24 PM
#3054 closed change (fixed)
Speed up interval between icon animations
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.9.3-for-Chrome-Opera-Safari-next |
| Module: | Platform | Keywords: | |
| Cc: | fhd, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
During the test of the Adblock Browser promotional notification we noticed that people either noticed it days later or not at all. Therefore we'd like to decrease the time between icon animations to make notifications more noticeable.
What to change
Reduce time between icon animation starts from 15,000ms to 10,000ms.
What to test
- Make sure the icon animates smoothly with a pause up to 7 seconds in between
- Make sure that CPU load doesn't get too high
- Also test in slow or busy environments
Attachments (0)
Change History (8)
comment:1 Changed on 09/10/2015 at 01:20:41 PM by sebastian
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 09/10/2015 at 01:21:00 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 09/10/2015 at 01:47:00 PM by fhd
comment:5 Changed on 09/10/2015 at 01:59:33 PM by greiner
- Owner set to greiner
comment:6 Changed on 09/10/2015 at 02:10:29 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 09/16/2015 at 04:58:56 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
comment:8 Changed on 09/17/2015 at 04:28:24 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Timing seems OK. CPU usage seems OK. Tested with busy background machine load (decompressing things) and "in-browser load" (loading several of complicated tabs before/during animations). Tested both animations.
ABP 1.9.2.1482
Chrome 45.0.2454.93 m / Windows 7 - 32bit
Chrome 45.0.2454.93 m / Ubuntu 14.04 - 64bit
Opera 32.0.1948.25 / Windows 7 - 32bit
Safari 7.0.6 / OS X 10.9
We discussed the interval in the review: Since those 10 (previously 15) seconds are the interval at which notifications are triggered, the time between notifications is, at most, 7 seconds - could be less, on some systems.