Opened on 09/14/2015 at 06:20:40 PM
Closed on 09/15/2015 at 01:06:00 PM
Last modified on 11/26/2015 at 01:26:35 PM
#3071 closed defect (fixed)
Element Hiding Helper broken in Thunderbird/SeaMonkey Mail
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Element-Hiding-Helper-1.3.5 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Thunderbird | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Thunderbird 38.2.0 or SeaMonkey 2.35 on OS X 10.10, Adblock Plus 2.6.10.3972-beta, Element Hiding Helper 1.3.4.508-beta.
How to reproduce
- Open a mail in Thunderbird or SeaMonkey Mail.
- Click ABP icon and choose "Select an element to hide"
- Click an element in the mail
Observed behaviour
Nothing happens, the error message "TypeError: this.browser.selectedBrowser is undefined" shows up in Error Console (pointing to aardvark.js line 615).
Problem is that the code here is expecting this.browser to be a <tabbrowser> whereas on Thunderbird and in SeaMonkey Mail we get a regular <browser> element.
Expected behaviour
The filter assistant should show up.
Attachments (0)
Change History (3)
comment:1 Changed on 09/14/2015 at 06:22:40 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/15/2015 at 01:06:00 PM by trev
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 11/26/2015 at 01:26:35 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
ABP 2.6.13 / EHH 1.3.5
Thunderbird 38.2.0 / Ubuntu 14.04
Thunderbird 38.4.0 / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/elemhidehelper/rev/d17f6f0a3801