Opened on 09/17/2015 at 07:28:45 PM

Closed on 08/29/2019 at 05:48:47 PM

#3096 closed defect (rejected)

Notification icon animation is not stopped after desktop notification is dismissed

Reported by:	Ross	Assignee:
Priority:	P3	Milestone:
Module:	Platform	Keywords:	closed-in-favor-of-gitlab
Cc:	fhd, sebastian, greiner, jsonesen, kzar	Blocked By:
Blocking:		Platform:	Chrome
Ready:	yes	Confidential:	no
Tester:	Ross	Verified working:	no
Review URL(s):

Description

Environment

ABP 1.9.2.1482
Chrome 45.0.2454.93 m / Ubuntu 14.04 - 64bit
Opera 32.0.1948.25 / Windows 7 - 32bit

How to reproduce

Create a notification.json like below and serve it.
Set the ABP notification URL to served notification.json.
Clear Prefs.notificationdata.
Restart Chrome.
Wait one minute.
Observe desktop notification with button appear.
Select the button on the notification.
Observe link is opened, notification is dismissed.
Wait ~10s. Observe ABP icon performs ! animation.
Select the ABP icon to open the popup UI.
Observe there is no notification present. Leave popup UI open.
Observe ABP icon perform ! animation again (and so on).

Observed behaviour

When selecting a link in a desktop notification, the desktop and popup UI notification are dismissed/closed however the icon keeps animating.

Expected behaviour

If the notification has been dismissed already the animation should be stopped.

Test data

{
  "notifications": [
    {
      "id": 1,
      "type": "critical",
      "title": "Title",
      "message": "Notification with <a>link</a>",
      "links": [ "link" ]
    }
  ],
  "version": "201509161000"
}

Change History (3)

comment:1 Changed on 10/20/2015 at 11:39:12 AM by kzar

Ready set

comment:2 Changed on 09/23/2017 at 05:13:28 PM by sebastian

Cc jsonesen kzar added

Ross just reminded me of this issue. Does anybody want to look into it? :)

comment:3 Changed on 08/29/2019 at 05:48:47 PM by sebastian

Keywords closed-in-favor-of-gitlab added
Resolution set to rejected
Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Summary:

Description:

You may use WikiFormatting here.

=== Environment ===
ABP 1.9.2.1482
Chrome 45.0.2454.93 m / Ubuntu 14.04 - 64bit
Opera 32.0.1948.25 / Windows 7 - 32bit

=== How to reproduce ===
 1. Create a notification.json like below and serve it.
 2. Set the ABP notification URL to served notification.json.
 3. Clear Prefs.notificationdata.
 4. Restart Chrome.
 5. Wait one minute.
 6. Observe desktop notification with button appear.
 7. Select the button on the notification.
 8. Observe link is opened, notification is dismissed.
 9. Wait ~10s. Observe ABP icon performs ! animation.
 10. Select the ABP icon to open the popup UI. 
 11. Observe there is no notification present. Leave popup UI open.
 12. Observe ABP icon perform ! animation again (and so on).

=== Observed behaviour ===
When selecting a link in a desktop notification, the desktop and popup UI notification are dismissed/closed however the icon keeps animating.

=== Expected behaviour ===
If the notification has been dismissed already the animation should be stopped.

=== Test data ===
{{{
{
  "notifications": [
    {
      "id": 1,
      "type": "critical",
      "title": "Title",
      "message": "Notification with <a>link</a>",
      "links": [ "link" ]
    }
  ],
  "version": "201509161000"
}
}}}

Type:

Priority:

Milestone:

Module:

Keywords:

Cc:

Blocked By:

Blocking:

Platform:

Ready:

Confidential:

Tester:

Verified working:

Review URL(s):

Context Navigation

#3096 closed defect (rejected)

Notification icon animation is not stopped after desktop notification is dismissed

Description

Environment

How to reproduce

Observed behaviour

Expected behaviour

Test data

Attachments (0)

Change History (3)

comment:1 Changed on 10/20/2015 at 11:39:12 AM by kzar

comment:2 Changed on 09/23/2017 at 05:13:28 PM by sebastian

comment:3 Changed on 08/29/2019 at 05:48:47 PM by sebastian

Add Comment

Modify Ticket

Changed by kzar

Download in other formats:

Summary:
Description:	You may use WikiFormatting here. === Environment === ABP 1.9.2.1482 Chrome 45.0.2454.93 m / Ubuntu 14.04 - 64bit Opera 32.0.1948.25 / Windows 7 - 32bit === How to reproduce === 1. Create a notification.json like below and serve it. 2. Set the ABP notification URL to served notification.json. 3. Clear Prefs.notificationdata. 4. Restart Chrome. 5. Wait one minute. 6. Observe desktop notification with button appear. 7. Select the button on the notification. 8. Observe link is opened, notification is dismissed. 9. Wait ~10s. Observe ABP icon performs ! animation. 10. Select the ABP icon to open the popup UI. 11. Observe there is no notification present. Leave popup UI open. 12. Observe ABP icon perform ! animation again (and so on). === Observed behaviour === When selecting a link in a desktop notification, the desktop and popup UI notification are dismissed/closed however the icon keeps animating. === Expected behaviour === If the notification has been dismissed already the animation should be stopped. === Test data === {{{ { "notifications": [ { "id": 1, "type": "critical", "title": "Title", "message": "Notification with <a>link</a>", "links": [ "link" ] } ], "version": "201509161000" } }}}
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):