Opened on 09/29/2015 at 01:10:33 PM
Closed on 10/02/2015 at 09:06:34 AM
#3136 closed change (fixed)
Only show about:feedback to users that installed via Play and have ABB_RELEASE_BUILD set
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.1.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
As of #2930, all users that installed via Google Play will see about:feedback, which asks them to rate the app. Users that installed the beta version from Google Play will, however, not be able to rate it. So we should not show it if it is a devbuild.
What to change
Only show about:feedback if ABB_RELEASE_BUILD is set.
Attachments (0)
Change History (5)
comment:1 Changed on 09/29/2015 at 01:11:47 PM by fhd
- Milestone set to Adblock-Browser-for-Android-1.1.0
comment:2 Changed on 09/29/2015 at 01:12:00 PM by fhd
- Milestone Adblock-Browser-for-Android-1.1.0 deleted
comment:3 Changed on 09/30/2015 at 09:02:54 AM by fhd
- Owner set to fhd
comment:4 Changed on 10/01/2015 at 02:27:54 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 10/02/2015 at 09:06:34 AM by fhd
- Milestone set to Adblock-Browser-for-Android-1.1.0
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Pushed: https://bitbucket.org/adblockplus/adblockbrowser/commits/1522b9474ddadc17af5abae6b042c092adaee8c0