Sitekey exception rules do not apply recursively in adblockpluschrome

[kzar]

Environment

Adblock Plus for Chrome version 1.9.3 (stable)

How to reproduce

1. Grab the script from ​https://gist.github.com/kzar/19c54d2456c0f060e9fc
2. Run it with Python
3. Browse to ​http://localhost:5000
4. Add the two filters that are listed at the top of the page (ads and the sitekey exception rule)
5. Refresh the page

Observed behaviour

Only the image outside of the frame is shown.

Expected behaviour

Both the image inside and the image outside of the frame should be shown. (This happens with the Firefox extension.)

[greiner]

Due to platform specifics, we look at the HTML "data-adblockkey" attribute only in Firefox and Safari while under Chromium we look at the "X-Adblock-Key" HTTP header. So as mentioned in the ​documentation both methods need to be implemented for it to work properly.

Therefore please check whether this issue also appears when the header is set and reopen it if that's the case.

[kzar]

But I'm pretty sure I am ​returning the X-Adblock-Key header correctly already.

$ curl -I http://localhost:5000
HTTP/1.0 200 OK
Content-Type: text/html; charset=utf-8
Content-Length: 575
X-Adblock-Key: MFwwDQYJKoZIhvcNAQEBBQADSwAwSAJBANGtTstne7e8MbmDHDiMFkGbcuBgXmiVesGOG3gtYeM1EkrzVhBjGUvKXYE4GLFwqty3v5MuWWbvItUWBTYoVVsCAwEAAQ==_ACqpNMPLn02zyLJMQY98QyJB89DHPQUvWa/hW4aA82A9t3DZzUuCHXGYfF2WNnHqSyQZdjdnimLujyiGkNiAUA==
Server: Werkzeug/0.10.4 Python/2.7.9
Date: Wed, 07 Oct 2015 11:33:11 GMT

[greiner]

Sorry, wasn't checking throughly enough. Indeed, the image inside the frame is not shown but that's not because it was blocked but because it was hidden. Presumably, this was done by element collapsing.

Note that I added the requirement for a blocking filter to the reproduction steps and removed EasyList which allows us to make sure that this behavior is independent of element hiding.

[sebastian]

Reproduced with Adblock Plus 1.9.3. This seems to be a regression, as it works correctly with 1.8.12. Firefox is fine as well. I'm going to do further bisecting.

[sebastian]

The regression was introduced by ​a400e15525fc. However, I don't understand yet why that change is causing this issue.

[greiner]

From what I see, the problem is that the sitekey is not passed to the defaultMatcher.matchesAny() call in background.js.

@sebastian Not sure either why it worked before but maybe element collapsing simply wasn't functioning properly. Let me know if you insist on investigating that aspect further because otherwise I'd start the review based on the reason I mentioned above.

[sebastian]

Yeah, I already gave up on anaylzing that change, and started to debug why this frame isn't considered whitelisted. Though I didn't figured anything out there either yet. If you want to take over, investigating this issue, fine with me.

[greiner]

​https://hg.adblockplus.org/adblockpluschrome/rev/26ff14245dff