Opened on 10/07/2015 at 03:54:09 PM
Closed on 06/30/2016 at 04:19:01 PM
#3177 closed change (fixed)
Respect the Expires header
| Reported by: | fhd | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-iOS-next |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | salsita 2015q4 |
| Cc: | mario | Blocked By: | #3176, #3395 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://github.com/adblockplus/adblockplussafariios/pull/29 |
||
Description (last modified by mario)
Background
#3176 adds meta data to the content blocker lists. One field in there is the Expires field, that defines how long the client should wait until the list is updated. We should respect this value, so we can be more flexible about adjusting the download interval.
What to change
When updating the list, the client should read the Expires header, if present, and schedule the next update check accordingly. If the Expires header is missing, the client should check for updates in five days.
Examples
Please find two example lists attached to this issue.
Attachments (1)
Change History (13)
comment:1 Changed on 10/07/2015 at 03:54:19 PM by fhd
- Summary changed from Support the Expires header to Respect the Expires header
comment:2 Changed on 10/07/2015 at 03:55:12 PM by fhd
- Component changed from Unknown to Adblock-Plus-for-iOS
comment:3 Changed on 10/07/2015 at 03:56:17 PM by mario
- Cc mario added
comment:4 Changed on 10/27/2015 at 10:08:54 AM by mario
- Keywords Salsita added
comment:5 Changed on 11/09/2015 at 02:52:40 PM by mario
- Keywords salsita 2015q4 added; Salsita removed
Changed on 12/08/2015 at 12:33:41 PM by mario
comment:7 Changed on 12/09/2015 at 08:11:15 AM by mario
- Blocked By 3395 added
comment:8 Changed on 03/07/2016 at 05:17:53 PM by jand
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 06/27/2016 at 02:59:18 PM by abpbot
comment:10 Changed on 06/27/2016 at 03:00:12 PM by fhd
- Review URL(s) modified (diff)
comment:11 Changed on 06/30/2016 at 04:18:02 PM by abpbot
A commit referencing this issue has landed:
Issue 3177 - Respect the Expires header
comment:12 Changed on 06/30/2016 at 04:19:01 PM by fhd
- Milestone set to Adblock-Plus-for-iOS-next
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 3177 - Added new cocoa pods dependency