Opened on 10/09/2015 at 04:15:17 PM

Closed on 10/09/2019 at 02:30:59 PM

#3187 closed change (duplicate)

Add tests for Acceptable Ads detection to testpages

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Ross, saroyanm, hseydel Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We provide whitelisting partners with the ability to check whether Acceptable Ads is enabled or not for performance measurements. Therefore we need to ensure that the extension always behaves the same.

What to change

  • Add a 1x1 pixel image px.gif
  • Add the following filters to exceptionrules.txt (may vary depending on the final URL of the image): 
    @@||testpages.adblockplus.org/px.gif?ch=1^$domain=testpages.adblockplus.org
||testpages.adblockplus.org/px.gif?ch=2^$domain=testpages.adblockplus.org
  • Add a new test checking the results of the following requests:
    • /px.gif?ch=1 should succeed (i.e. 2xx or 3xx response codes)
    • /px.gif?ch=2 should fail (i.e. 4xx or 5xx response codes)

Attachments (0)

Change History (8)

comment:1 Changed on 11/26/2015 at 05:43:52 PM by saroyanm

  • Cc saroyanm added

comment:2 Changed on 11/11/2016 at 07:38:30 PM by juliandoucette

  1. Is this still relevant?
  2. We should split this up into two issues because exceptionrules.txt is not part of testpages.adblockplus.org?

comment:3 Changed on 11/14/2016 at 11:35:31 AM by greiner

  • Cc hseydel added

Is this still relevant?

Unless Henning disagrees, I'd still consider this to be relevant.

comment:4 Changed on 04/13/2017 at 12:01:36 PM by juliandoucette

  • Priority changed from Unknown to P5

comment:5 Changed on 07/12/2017 at 02:49:01 PM by juliandoucette

I don't know how to move this forward @greiner.

comment:6 Changed on 07/12/2017 at 03:33:22 PM by greiner

Neither do I. Note that it affects testpages.adblockplus.org so we probabaly need Ross for that since he's the owner of this repository because ​it's not part of any module.

comment:7 Changed on 04/09/2018 at 05:08:08 PM by juliandoucette

  • Component changed from Websites to Unknown
  • Priority changed from P5 to Unknown

comment:8 Changed on 10/09/2019 at 02:30:59 PM by greiner

  • Resolution set to duplicate
  • Status changed from new to closed

Closing this ticket as duplicate of ​AAP-942 (internal).

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.