Opened on 10/13/2015 at 08:09:29 AM

Closed on 10/13/2015 at 11:04:58 AM

#3196 closed defect (fixed)

Correct misuse of $alias metaparameter

Reported by: matze Assignee: matze
Priority: P1 Milestone:
Module: Infrastructure Keywords:
Cc: fred, fhd Blocked By:
Blocking: #3088 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29329059

Description

In #2814 we introduced type filtermaster::repo_download which features an $alias parameter. This one is actually considered a metaparameter by Puppet (allowing to alias a resource for later reference), yet our use of it is completely different (allowing to separate the repository from the directory name).

Todo

Replace the $alias by something more appropriate, e.g. $target, adjust the documentation accordingly, and address the changes in both the development and production setup in Hiera.

Attachments (0)

Change History (2)

comment:1 Changed on 10/13/2015 at 09:08:15 AM by matze

  • Cc fhd added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/13/2015 at 11:04:58 AM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/infrastructure/rev/2ec50429ae01

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.