Opened on 10/27/2015 at 03:50:29 PM
Closed on 12/01/2015 at 11:19:01 AM
Last modified on 12/01/2015 at 11:25:14 AM
#3240 closed change (fixed)
Replace old Adblock Browser icon with new one
| Reported by: | sven | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-iOS-1.2.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | salsita, mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Shikitita | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by fhd)
Background
We're using an old Adblock Browser icon for the app on different places.
What to change
Replace old Adblock Browser icon with new one.
App icon
- AdblockBrowser_iOS_AppIcon_76x76
- AdblockBrowser_iOS_AppIcon_120x120
- AdblockBrowser_iOS_AppIcon_152x152
- AdblockBrowser_iOS_AppIcon_167x167
- AdblockBrowser_iOS_AppIcon_180x180
Settings icon
- AdblockBrowser_iOS_SettingsIcon_29x29
- AdblockBrowser_iOS_SettingsIcon_58x58
- AdblockBrowser_iOS_SettingsIcon_87x87
Spotlight search icon
- AdblockBrowser_iOS_SpotlightSearch_60x60
- AdblockBrowser_iOS_SpotlightSearch_80x80
- AdblockBrowser_iOS_SpotlightSearch_120x120
- AdblockBrowser_iOS_SpotlightSearch_180x180
- AdblockBrowser_iOS_SpotlightSearch_100x100
- AdblockBrowser_iOS_SpotlightSearch_114x114
- AdblockBrowser_iOS_SpotlightSearch_144x144
Hints for testers
These icons are used within iOS, we provide them according to Apple's specifications.
The app icon is used on the home screen, the settings icon is used for the app's section in the iOS settings, the spotlight search icon is displayed in the spotlight search results when searching for the app name.
Attachments (15)
Change History (33)
comment:1 Changed on 10/27/2015 at 03:57:25 PM by sven
- Cc salsita mario added
- Description modified (diff)
comment:2 Changed on 10/29/2015 at 02:25:37 PM by jand
comment:3 Changed on 10/29/2015 at 02:37:26 PM by sven
Seems to be an export issue. Thx for having a look at that. I will quickly fix that.
Changed on 10/29/2015 at 04:33:08 PM by sven
Changed on 10/29/2015 at 04:33:19 PM by sven
Changed on 10/29/2015 at 04:33:27 PM by sven
Changed on 10/29/2015 at 04:33:34 PM by sven
Changed on 10/29/2015 at 04:33:45 PM by sven
Changed on 10/29/2015 at 04:33:53 PM by sven
Changed on 10/29/2015 at 04:34:00 PM by sven
Changed on 10/29/2015 at 04:34:21 PM by sven
Changed on 10/29/2015 at 04:34:27 PM by sven
Changed on 10/29/2015 at 04:34:33 PM by sven
Changed on 10/29/2015 at 04:34:40 PM by sven
Changed on 10/29/2015 at 04:34:47 PM by sven
Changed on 10/29/2015 at 04:34:53 PM by sven
Changed on 10/29/2015 at 04:35:00 PM by sven
Changed on 10/29/2015 at 04:35:13 PM by sven
comment:5 Changed on 10/29/2015 at 04:39:58 PM by sven
Should be ready now.
comment:6 Changed on 10/30/2015 at 03:59:17 PM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed on 11/03/2015 at 09:12:13 AM by philll
This issue was never set to ready and simply isn't in it's current form. The description does not state where to find any of the changed icons, thus making this completely untestable.
Please describe in great detail, where to find the changed icons.
comment:9 Changed on 11/03/2015 at 12:00:25 PM by fhd
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
This is indeed hard to test. Updated the description a little and added hints for testers, so that we can verify that we're setting these icons correctly.
That's all we need to test IMO. How Apple uses those icons is their business, we have no control over it. We provide icons according to their specifications, that's all we can do. Therefore, testing one occurrence should suffice.
comment:10 Changed on 11/03/2015 at 12:01:31 PM by fhd
- Description modified (diff)
comment:11 Changed on 11/04/2015 at 10:36:07 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:12 Changed on 11/13/2015 at 08:36:44 AM by michal.kuric
- Resolution fixed deleted
- Status changed from closed to reopened
An old icon is displayed in iOS 8.4.1 spotlight search (build 1.2.0-QA - 600). Tested on iPhone 5C.
comment:13 Changed on 11/19/2015 at 12:02:24 PM by mario
Batch Modify: Added milestone Adblock-Browser-for-iOS-next for upcoming release.
comment:14 Changed on 11/25/2015 at 02:58:37 PM by Shikitita
Would it be possible to know what the exact difference is between the old icon and the new one?
comment:15 Changed on 11/25/2015 at 04:17:13 PM by michal.kuric
- Resolution set to fixed
- Status changed from reopened to closed
Correct icon shown after nobody did any changes in a code for this purpose.
The old icon was missing a shadow casting on "earth" from the red part of icon.
comment:16 Changed on 12/01/2015 at 10:46:14 AM by Shikitita
- Resolution fixed deleted
- Status changed from closed to reopened
comment:17 Changed on 12/01/2015 at 11:19:01 AM by mario
- Resolution set to fixed
- Status changed from reopened to closed
Remark on why it was reopened and closed again: Shikitita raised concerns regarding a missing icon. However, that wasn't in the scope of this issue and will be handled within a separate issue.
comment:18 Changed on 12/01/2015 at 11:25:14 AM by Shikitita
- Tester changed from Unknown to Shikitita
- Verified working set
sven: Size of icon is complete mishmash ( size of icon 180x180 is 181x180, icon 120× 120 is 121 x 120, etc). Icons of size 114x114, 100x100 and 144x144 are missing.
Am I allowed to fix the sizes of the icons and create missing ones?