Opened on 11/11/2015 at 08:43:54 AM
Closed on 01/08/2016 at 06:20:13 PM
Last modified on 12/15/2016 at 06:18:30 AM
#3300 closed defect (fixed)
Facebook preview images not showing
| Reported by: | arthur | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | sergz, oleksandr | Blocked By: | #3303, #3343 |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | no | Confidential: | no |
| Tester: | Rraceanu | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
ABP 1.5
EasyList enabled
IE 11.0.10240.16431
Windows 10
How to reproduce
Observed behaviour
The preview image in the post is showing for a split second (when refreshing via Ctrl+F5) and then disappears. Disabling ABP for facebook.com makes it appear again.
Expected behaviour
The image should always show.
Attachments (0)
Change History (11)
comment:1 Changed on 11/11/2015 at 03:29:34 PM by sergz
comment:2 Changed on 11/12/2015 at 11:42:16 AM by sergz
Interesting that neither in Firefox nor in Chrome the URL seems to be not decoded before matching the filter, so it is the reason it's not blocked there.
comment:3 Changed on 11/16/2015 at 04:12:35 AM by oleksandr
- Priority changed from Unknown to P3
- Ready set
Chrome uridecodes the address part of the URL, leaving the query string intact. We should do the same.
comment:4 Changed on 11/16/2015 at 09:22:01 PM by oleksandr
- Blocked By 3303 added
comment:5 Changed on 11/16/2015 at 09:22:18 PM by oleksandr
- Ready unset
comment:6 Changed on 11/23/2015 at 02:34:28 PM by oleksandr
- Blocked By 3343 added
comment:7 Changed on 01/08/2016 at 05:27:48 PM by eric@adblockplus.org
We've retired #3343. Did that change fix this problem?
comment:8 Changed on 01/08/2016 at 06:20:13 PM by oleksandr
- Resolution set to fixed
- Status changed from new to closed
Yes, it seems like it is fixed now, based on my tests. This should be included in the next devbuild and ABP for IE 1.6
comment:9 Changed on 01/11/2016 at 02:51:21 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:10 Changed on 11/08/2016 at 12:59:49 AM by rraceanu
- Tester changed from Unknown to Rraceanu
comment:11 Changed on 12/01/2016 at 01:30:46 AM by rraceanu
- Verified working set
Fix implemented successfully on ABP for IE 1.5.856 for IE 11.447.14393.0 and IE 11.103.14393.0 Windows 10 Home and Pro, also IE 10 on Windows 8, preview thumbnails load correctly.
It's blocked by CPluginDomTraverser, for img tags it checks whether the request in src should be blocked or not and hides the element if src is blocked. In this particular case the URL is https://external-frt3-1.xx.fbcdn.net/safe_image.php?d=AQDG18hXt4a9ZX9b&w=470&h=246&url=https://www.facebook.com/ads/image/?d=AQLBPIefFK_mcLEvFR-mVwHgciv-NMbof-t6UHSCX76geZci_sFNFvKnjbX5wekR58St4JQM8Gyb5uC2HL_4JEAr21I9_kSY_cS9ZDopWQKqpfarzLe_AApWcqjl4T0-YgngkHPjujuuMiYlfkl_urqt&cfs=1&upscale=1 and the corresponding blocking filter is /ads/image/*.
FYI: #3303.
The question is, how to fix it?