Opened on 11/16/2015 at 02:06:14 PM

Closed on 11/16/2015 at 05:51:49 PM

#3327 closed change (fixed)

Set minVersion correctly when exporting $generichide or $genericblock filters

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.6.12-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29330225/

Description

When exporting filters to .ini file from Filter Preferences, the file header should be [Adblock Plus 2.6.12] if any $generichide or $genericblock filters are present.

Attachments (0)

Change History (2)

comment:1 Changed on 11/16/2015 at 02:20:56 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/16/2015 at 05:51:49 PM by trev

  • Milestone set to Adblock-Plus-2.6.12-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed to default and release branch:

​https://hg.adblockplus.org/adblockplus/rev/4f4db95e3e35
​https://hg.adblockplus.org/adblockplus/rev/38734339b8a8

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.