Opened on 11/17/2015 at 06:24:55 PM
Closed on 11/17/2015 at 10:07:37 PM
Last modified on 11/17/2015 at 10:08:12 PM
#3336 closed change (rejected)
Update adblockplustests repository dependency to revision 94a67e14fda9
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | trev, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We should update the adblockplustests dependency before releasing Adblock Plus for Chrome/Opera/Safari 1.9.4. The following changes will be included:
Issue 616 - Add tests for $generichide,genericblock filter options
Marked compatible with Firefox 45 & Co.
Issue 132 - Add README to adblockplustests repository
Issue 2715 - Speed up notification target tests
Issue 3208 - Adjust unit tests for the content policy changes
What to change
Updating the dependency should be sufficient.
What to test
- That the unit tests still pass.
Attachments (0)
Change History (3)
comment:1 Changed on 11/17/2015 at 06:39:25 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/17/2015 at 10:07:37 PM by sebastian
- Cc sebastian added
- Resolution set to rejected
- Status changed from reviewing to closed
comment:3 Changed on 11/17/2015 at 10:08:12 PM by sebastian
- Milestone Adblock-Plus-for-1.9.4-Chrome-Opera-Safari deleted
Note: See
TracTickets for help on using
tickets.
None of these changes effect any (test) code imported into Adblock Plus for Chrome, Opera and Safari. Please only update dependencies if there are actual changes in the reused code.