Context Navigation

Opened on 11/24/2015 at 09:04:37 AM

Closed on 11/24/2015 at 09:13:46 AM

#3344 closed change (fixed)

Now that jsshydra fetches the proper jsshell version #2956, we should update the jsshydra dependency in buildtools.

Updating the dependency should be sufficient.

The following changes will be included:

That builds, for example adblockpluschrome, still work with the changes.
That the new and old jsshell directories are properly ignored by both Git and Mercurial.

You may use WikiFormatting here.

Change Properties

Summary:
Description:	You may use WikiFormatting here. === Background === Now that jsshydra fetches the proper jsshell version #2956, we should update the jsshydra dependency in buildtools. === What to change === Updating the dependency should be sufficient. The following changes will be included: [https://hg.adblockplus.org/jshydra/rev/eb1951d3c84f Noissue - Add .gitignore file] [https://hg.adblockplus.org/jshydra/rev/d12e56ff8e13 Issue 2956 - Ensure the correct version of jsshell is present] [https://hg.adblockplus.org/jshydra/rev/d6dd3cd33779 Noissue - Make sure to close the urllib response object] === What to test === - That builds, for example adblockpluschrome, still work with the changes. - That the new and old jsshell directories are properly ignored by both Git and Mercurial.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):

Action

leave as closed .

reopen The resolution will be deleted. Next status will be 'reopened'.

reassign to The owner will be changed from kzar.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.