Opened on 11/25/2015 at 12:47:48 PM

Closed on 11/25/2015 at 01:30:28 PM

Last modified on 11/26/2015 at 01:26:20 PM

#3348 closed defect (fixed)

Element Hiding Helper UI broken after bug 1182546 landing

Reported by: trev Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.5
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29330776/

Description

Environment

Firefox 45.0a1 (2015-11-24), Element Hiding Helper 1.3.4

How to reproduce

  1. Start up Firefox

Observed behaviour

XML parsing error in the browser window, extension user interface is broken. See ​​https://bugzilla.mozilla.org/show_bug.cgi?id=1226823 for more information.

Expected behaviour

EHH menu item should show up in the Adblock Plus menu as usually.

Attachments (0)

Change History (3)

comment:1 Changed on 11/25/2015 at 12:53:41 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/25/2015 at 01:30:28 PM by trev

  • Milestone set to Element-Hiding-Helper-1.3.5
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed:

​https://hg.adblockplus.org/elemhidehelper/rev/04293fd8c60e

comment:3 Changed on 11/26/2015 at 12:59:55 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

ABP 2.6.13 / EHH 1.3.5
Firefox 45.0a1 (2015-11-24) / Ubuntu 14.04

Last edited on 11/26/2015 at 01:26:20 PM by Ross

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.