Opened on 11/28/2015 at 12:49:02 PM
Closed on 12/02/2015 at 02:09:59 PM
Last modified on 12/14/2015 at 11:00:40 AM
#3357 closed change (fixed)
Get rid of chrome://adblockplus/content/errors.html
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
chrome://adblockplus/content/errors.html was originally introduced because the Error Console was being disabled for regular users, and because users had trouble filtering it when looking for ABP-related errors. The idea was that users would open that page and immediately see if something is wrong.
Unfortunately, I don't remember a single case where this page helped diagnose a problem. Also, typing or copying it into the address bar isn't really simpler than pressing Ctrl-Shift-J (this hotkey works for all users apparently). And finding the relevant messages is still problematic, the filtering on errors.html is far from perfect (besides, similar error filtering functionality was added to the Issue Reporter).
On the other hand, errors.html has issues that trigger warnings in AMO validator: it uses document.write and a lengthy inline script. These can be solved of course, but given that the page isn't very useful in general the effort doesn't seem to be justified.
What to change
Removing errors.html from the build should be sufficient. The page is completely self-contained, it doesn't reference any external code and isn't referenced by anything either.
Attachments (0)
Change History (4)
comment:1 Changed on 12/02/2015 at 01:16:20 PM by trev
- Owner set to trev
comment:2 Changed on 12/02/2015 at 01:16:33 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/02/2015 at 02:09:59 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 12/14/2015 at 11:00:40 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Cannot visit/open the page now.
ABP 2.6.13.4091-beta
Firefox 45 Nightly (2015-12-13) / Ubuntu 14.04
Fixed: https://hg.adblockplus.org/adblockplus/rev/b4a7f30d04c3