Opened on 12/04/2015 at 09:48:05 PM

Closed on 01/08/2016 at 10:10:41 PM

Last modified on 01/19/2016 at 11:19:03 AM

#3380 closed defect (fixed)

synchronizer unit tests are broken

Reported by:	erikvold	Assignee:	erikvold
Priority:	P4	Milestone:	Adblock-Plus-2.7.1-for-Firefox
Module:	Adblock-Plus-for-Firefox	Keywords:
Cc:	trev	Blocked By:
Blocking:		Platform:	Firefox
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29332065

Description (last modified by trev)

Environment

OSX, Firefox Nighty 45.0a1 (2015-12-04)

How to reproduce

Run synchronizer unit tests

Observed behaviour

Every test in this suite appears to fail with the same error:

beforeEach failed on Downloads of one subscription: SynchronizerModule.downloader is undefined@ 1 ms
Source: 	

.setup/<@chrome://adblockplustests/content/tests/synchronizer.js:20:9
setupVirtualTime@chrome://adblockplustests/content/common.js:157:5
.setup@chrome://adblockplustests/content/tests/synchronizer.js:17:1

Died on test #2 @chrome://adblockplustests/content/tests/synchronizer.js:64:3
@chrome://adblockplustests/content/tests/synchronizer.js:1:2
: testRunner.registerHandler is not a function@ 3 ms
Source: 	

@chrome://adblockplustests/content/tests/synchronizer.js:70:5

afterEach failed on Downloads of one subscription: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]@ 3 ms
Source: 	

ObserverInterposition.methods.removeObserver@resource://gre/modules/RemoteAddonsParent.jsm:388:5
AddonInterpositionService.prototype.interposeProperty/desc.value@resource://gre/components/multiprocessShims.js:160:52
restoreVirtualTime@chrome://adblockplustests/content/common.js:280:3
.teardown@chrome://adblockplustests/content/tests/synchronizer.js:35:7

Expected behaviour

passing tests.

Background

This is fallout from bug 673569, the unit tests are accessing private module variables which are no longer global.

What to change

Make the affected variables properly global (change let to var).

Change History (7)

comment:1 Changed on 12/04/2015 at 09:48:57 PM by erikvold

Summary changed from synchronizer unit tests are borken to synchronizer unit tests are broken

comment:2 Changed on 12/07/2015 at 01:45:43 PM by trev

Cc trev added
Description modified (diff)

comment:3 Changed on 12/07/2015 at 03:17:50 PM by trev

Description modified (diff)
Priority changed from Unknown to P4
Ready set

comment:4 Changed on 12/07/2015 at 03:18:28 PM by trev

Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox

comment:5 Changed on 12/07/2015 at 03:45:57 PM by erikvold

Owner set to erikvold
Review URL(s) modified (diff)

comment:6 Changed on 01/08/2016 at 10:10:41 PM by erikvold

Resolution set to fixed
Status changed from new to closed

https://hg.adblockplus.org/adblockplus/rev/05e0bbeaaabd

comment:7 Changed on 01/19/2016 at 11:19:03 AM by trev

Milestone set to Adblock-Plus-for-Firefox-next

Context Navigation