Opened on 12/06/2015 at 07:43:19 PM
Closed on 12/08/2015 at 04:05:58 PM
Last modified on 11/21/2016 at 10:48:47 AM
#3383 closed change (fixed)
Clean up browser-site handling in CPluginClass
| Reported by: | eric@adblockplus.org | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | #3382 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
CPluginClass has a number of deficiencies involving its site pointer.
What to change
- Make initialization parallel: assign site pointer at the beginning, assign nullptr at the end.
- Remove unnecessary synchronization around the site pointer.
- Eliminate use of FinalConstruct and FinalRelease. This pair were not needed.
Attachments (0)
Change History (4)
comment:1 Changed on 12/06/2015 at 07:43:38 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:2 Changed on 12/07/2015 at 03:25:13 PM by oleksandr
- Cc oleksandr added
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 12/08/2015 at 04:05:58 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 11/21/2016 at 10:48:47 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See
TracTickets for help on using
tickets.
https://codereview.adblockplus.org/29323561/