Opened on 04/16/2014 at 11:58:20 AM

Closed on 04/16/2014 at 01:15:13 PM

Last modified on 04/22/2014 at 08:27:51 AM

#339 closed defect (fixed)

Filter classes unit tests fail in Chrome

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4846749680140288

Description

How to reproduce

  1. Install Adblock Plus from development environment.
  2. Open Adblock Plus options, then replace options.html in the URL bar by qunit/index.html
  3. Inspect unit test results

Observed behaviour

Two unit tests fail, the invalid filters #dd(asd)(ddd) and #* don't list the reason why they are invalid.

Expected behaviour

All unit tests should succeed.

Attachments (0)

Change History (3)

comment:1 Changed on 04/16/2014 at 11:59:34 AM by trev

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/16/2014 at 01:15:13 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockpluschrome/rev/8113faf81d55

comment:3 Changed on 04/22/2014 at 08:27:51 AM by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.