Opened on 12/08/2015 at 05:54:02 PM
Last modified on 07/08/2016 at 04:35:05 PM
#3394 new change
Factor out status bar into a separate class
Reported by: | eric@adblockplus.org | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Unknown | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #712, #3382, #3765 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by eric@adblockplus.org)
Background
CPluginClass is something of a god object. All of the code for the status bar icon and its associated menu is part of this class at present.
What to change
- Extract all the status bar code into a separate class.
- If possible, share a single status bar object between multiple instances of CPluginClass.
- Ensure the life cycle of the new class is in harmony with CPluginClass
- Define clear responsibilities for the new class and the remnant CPluginClass
- The status bar class is responsible for correctly displaying its status relative to the current tab. It does not have responsibility for determining that status; it asks another class.
Attachments (0)
Change History (5)
Note: See
TracTickets for help on using
tickets.
This relates to issue #3382 to rationalize the life cycle of some of the user interface members of CPluginClass.