Opened on 12/14/2015 at 07:25:43 AM
Closed on 01/06/2016 at 12:07:16 PM
Last modified on 01/18/2016 at 01:58:37 AM
#3407 closed defect (fixed)
Warning "unsafe CPOW usage" spammed to console when list of blockable items is open
| Reported by: | Ross | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s |
| Cc: | trev | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29333159/ |
||
Description (last modified by trev)
Environment
ABP 2.6.13.4091-beta / Firefox 45 Nightly
How to reproduce
- Install ABP.
- Click ABP icon in toolbar and choose "Open blockable items".
- Open the Firefox error console (CTRL+SHIFT+J)
- Navigate around to a page with content.
- Observe warnings in the console.
Observed behaviour
The warning "unsafe CPOW usage" is repeated to the console. The warnings references requestNotifier.js:228, contentPolicy.js:346, contentPolicy.js:378.
Expected behaviour
No such warnings should appear.
Background
The list of blockable items will still access the content window directly in order to determine whether it is whitelisted. This needs to be replaced by an E10S-safe approach.
Hints for testers
In addition to blockable items functionality, one has to test that the content area is focused after the blockable items are closed.
Attachments (0)
Change History (15)
comment:2 Changed on 12/14/2015 at 07:33:36 AM by Ross
comment:3 Changed on 12/14/2015 at 01:56:33 PM by trev
- Milestone Adblock-Plus-for-Firefox-next deleted
comment:4 Changed on 12/14/2015 at 02:00:19 PM by trev
- Cc trev added
Judging by the line numbers you had the list of blockable items open. That's an important detail that would be worth mentioning ;-)
Yes, we are still using CPOWs there which needs to be addressed, but definitely not for the next release.
comment:5 Changed on 12/14/2015 at 02:03:21 PM by trev
This is completely unrelated to #2879 by the way - not even the same extension.
comment:6 Changed on 12/14/2015 at 02:09:27 PM by trev
- Description modified (diff)
- Keywords e10s added
- Ready set
- Summary changed from Warning "unsafe CPOW usage" spammed to console in Nightly to Warning "unsafe CPOW usage" spammed to console when list of blockable items is open
comment:7 Changed on 01/04/2016 at 07:32:07 PM by trev
- Owner set to trev
comment:8 Changed on 01/04/2016 at 07:35:15 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:10 Changed on 01/04/2016 at 07:38:20 PM by trev
- Description modified (diff)
comment:11 Changed on 01/04/2016 at 08:10:05 PM by trev
- Review URL(s) modified (diff)
comment:12 Changed on 01/04/2016 at 08:25:28 PM by trev
- Review URL(s) modified (diff)
comment:13 Changed on 01/05/2016 at 09:39:08 AM by trev
One part landed here: https://hg.adblockplus.org/adblockplus/rev/b0824dcb1259
This is a marginally related change however, only about closing the blockable items.
comment:14 Changed on 01/06/2016 at 12:07:16 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Fixed the other part: https://hg.adblockplus.org/adblockplus/rev/b2f7cad2fd50
comment:15 Changed on 01/18/2016 at 01:58:37 AM by Ross
- Verified working set
No longer see this warning in the console when using the blockable items list.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64
Ah, I just noticed #2879. We can close this if you want but it does make looking for problems in the console more difficult.