Opened on 12/15/2015 at 03:50:35 PM
Closed on 12/15/2015 at 06:08:44 PM
Last modified on 12/16/2015 at 05:14:11 PM
#3415 closed change (fixed)
Detect application based on UA for Chromium-based browsers
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Currently, info.application is hard-coded to "chrome" and "opera" in the respective builds. However, when we use a unified build for all Chromium-based browsers (currently under discussion) that won't work anymore. But even until then this information is redundant with addonName which is "adblockpluschrome" and "adblockplusopera" respectively, at the moment. Moreover, currently, other Chromium-based browser (e.g. Yandex.Browser) are mistakenly reported as Chrome.
What to change
- Detect info.application on the client-side, based on the user agent string.
- Also make sure that info.applicationVersion refers to that application.
Attachments (0)
Change History (4)
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/buildtools/rev/bd59d0bc67cb