Opened on 12/17/2015 at 10:03:01 AM

Closed on 12/17/2015 at 10:56:24 AM

#3427 closed defect (fixed)

First Run actions are not performed

Reported by: Ross Assignee: trev
Priority: P1 Milestone: Adblock-Plus-1.10-for-Chrome-Opera-Safari
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332839/

Description (last modified by trev)

Environment

ABP 1.9.4.1503
Chrome 47.0.2526.80 / Ubuntu 14.04 x64

How to reproduce

  1. Uninstall ABP / Reset to clean state.
  2. Install latest ABP dev build from store link.
  3. Observe extension is installed and Chrome points it out.
  4. Observe the FRP is not opened.
  5. Select [ABP] > [Options].
  6. Observe no default filter lists are installed.
  7. Observe Acceptable Ads checkbox is not by default checked.

...

Observed behaviour

The "First Run" actions such as showing a First Run Page, adding default filter lists and setting the AA checkbox are not performed.

Expected behaviour

The "First Run" actions to complete successfully.

Background

ext.EventTarget doesn't correctly handle the case where a listener will remove itself when called - the next listener will be skipped in loop then.

Attachments (0)

Change History (7)

comment:1 Changed on 12/17/2015 at 10:05:06 AM by Ross

This also occurs as described in Opera.

ABP 1.9.4.1503
Opera 34.0.2036.25 / Ubuntu 14.04 x64

comment:2 Changed on 12/17/2015 at 10:12:12 AM by philll

  • Component changed from Extensions-for-Adblock-Plus to Unknown
  • Milestone Adblock-Plus-1.9.5-for-Chrome-Opera-Safari deleted
  • Priority changed from P2 to P1

comment:3 Changed on 12/17/2015 at 10:13:15 AM by philll

  • Ready set

comment:4 Changed on 12/17/2015 at 10:18:00 AM by philll

This behaviour started with Adblock Plus for Google Chrome 1.9.4.1501

comment:5 Changed on 12/17/2015 at 10:48:32 AM by trev

  • Description modified (diff)
  • Owner set to trev

comment:6 Changed on 12/17/2015 at 10:52:08 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 12/17/2015 at 10:56:24 AM by trev

  • Milestone set to Adblock-Plus-1.9.5-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.