Opened on 12/17/2015 at 02:37:18 PM
Closed on 12/17/2015 at 08:58:36 PM
#3430 closed change (fixed)
Get rid of expression closure in EHH's common.js
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Element-Hiding-Helper-1.3.6 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Expression closures are deprecated and cause a warning in Firefox 45. Yet it seems that we still have one instance in Element Hiding Helper's common.js.
What to change
Replace the expression closure by a regular function.
Attachments (0)
Change History (2)
comment:1 Changed on 12/17/2015 at 02:39:24 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/17/2015 at 08:58:36 PM by trev
- Milestone set to Element-Hiding-Helper-next
- Platform changed from Unknown / Cross platform to Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/elemhidehelper/rev/150abc7d2455