Opened on 12/21/2015 at 02:45:37 PM
Closed on 01/05/2016 at 01:04:32 PM
Last modified on 02/01/2016 at 07:44:54 AM
#3446 closed change (fixed)
Remove code migrating prefs and files to chrome.storage
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.10.1-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
In Adblock Plus 1.9, we migrated from localStorage and the FileSystem API to chrome.storage (#2040, #2021). The respective migration code soon has been in the extension for 8 months and 6 releases. So almost all users migrated already and that code can be removed now.
What to change
Remove the code that migrates prefs and files to chrome.storage, as well as the respective migration code for Safari which unifies the data structure.
Hints for testers
Make sure that extension initialization works, i.e. that default filter lists are configured and that the first run page shows up on installation; that settings are preserved when updating the extension (from ABP 1.9 or any newer version) or restarting the browser.
Attachments (0)
Change History (5)
comment:1 Changed on 12/21/2015 at 02:49:08 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/05/2016 at 01:04:32 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 01/29/2016 at 02:20:59 PM by kzar
- Cc kzar added
comment:5 Changed on 02/01/2016 at 07:44:41 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
Done.
- The extension re-initialises after restart
- The settings are preserved when updating the extension
- The extension loads the default lists
- The first run page shows up on first installation
Safari 6, 7, 8
Chrome 36, 37, 44, 45, 46, 48
Opera 28, 29, 30
https://hg.adblockplus.org/adblockpluschrome/rev/3965833c29ec