Opened on 12/22/2015 at 11:37:48 AM
Closed on 01/04/2016 at 05:21:20 PM
#3451 closed defect (fixed)
Previously disabled filter is re-added as disabled when whitelisting a site
| Reported by: | mapx | Assignee: | greiner |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
windows xp
FF 440b1
easylist
ABP 2.7.0.4098
How to reproduce
- go to google.com
- click ABP icon, click "disable on google.com"
- refresh page
- go to custom filters
- uncheck (disable) the filter
@@||google.com^$document
- refresh
- delete filter from custom filters
- click again "disable on google.com"
Observed behaviour
the filter will be created but disabled. The site / page is not whitelisted.
Expected behaviour
the page / site should be whitelisted
Attachments (0)
Change History (6)
comment:1 Changed on 01/04/2016 at 04:46:02 PM by greiner
comment:2 Changed on 01/04/2016 at 04:59:54 PM by trev
- Priority changed from Unknown to P4
- Ready set
comment:3 Changed on 01/04/2016 at 05:00:31 PM by trev
- Summary changed from whitelisting site - tricky behaviour to Previously disabled filter is re-added as disabled when whitelisting a site
comment:4 Changed on 01/04/2016 at 05:00:50 PM by greiner
- Owner set to greiner
comment:5 Changed on 01/04/2016 at 05:05:06 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 01/04/2016 at 05:21:20 PM by greiner
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I can confirm this issue.
Note that setting filter.disabled = false before adding it to the filter storage in UI.toggleFilter() fixes it.