Opened on 01/04/2016 at 05:26:27 PM

Closed on 01/04/2016 at 07:43:58 PM

#3464 closed defect (fixed)

"subscriptionUpdateDataSource is undefined" error in Issue Reporter

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29333147/

Description

Environment

Firefox 44 and higher, Adblock Plus 2.7.

How to reproduce

  1. Make sure your filter subscriptions aren't up-to-date (restore backup if necessary).
  2. Go to ​http://www.diynetwork.com/photos/top-pins-from-2015-pictures
  3. Click ABP icon and choose "Report issue on this page."
  4. Choose "Adblock Plus is blocking too much" and click Continue.

Observed behaviour

The message "Adblock Plus needs to update your filter subscriptions" appears but it never goes away unless you click Continue yourself. The message "ReferenceError: subscriptionUpdateDataSource is not defined" appears in the Error Console. Filter subscriptions stay outdated.

Expected behaviour

Filter subscriptions are updated and the wizard continues automatically, no errors thrown.

Background

This is yet again fallout from ​bug 1202902.

Attachments (0)

Change History (2)

comment:1 Changed on 01/04/2016 at 05:41:08 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/04/2016 at 07:43:58 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/ef8e5d19b9a4

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.