Opened on 01/06/2016 at 03:30:34 PM
Closed on 02/11/2016 at 09:33:51 AM
Last modified on 03/08/2016 at 06:47:27 AM
#3477 closed defect (fixed)
window.close makes the tab ignore following JS activity
| Reported by: | pavelz | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-iOS-1.3.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | salsita |
| Cc: | mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Environment
iPhone 6
iOS 9.2
ABB 1.2.1
How to reproduce
Open a website in Adblock Browser containing the following Java Script:
function magic () {
window.close();
window.open("http://adblockplus.org", "_blank");
}
window.setTimeout(magic, 1000);
Observed behaviour
window.open is not executed and thus "adblockplus.org" is not opened.
Expected behaviour
window.open is executed and thus "adblockplus.org" is opened.
Background
window.close does not mean that the current JS context immediately disappears, it continues execution. But in the example above window.open is ignored.
While, from a certain point of view the original behaviour makes sense, the behavior of all other browsers is imperative. The commands keep being executed normally until the current event loop finishes.
Attachments (0)
Change History (9)
comment:1 Changed on 01/07/2016 at 03:01:46 PM by mario
- Cc mario added
- Description modified (diff)
- Keywords salsita added
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 01/12/2016 at 08:41:01 AM by pavelz
- Blocking 3483 added
comment:3 Changed on 01/28/2016 at 10:24:05 AM by pavelz
comment:4 Changed on 02/09/2016 at 04:18:19 PM by pavelz
- Blocking 3483 removed
comment:5 Changed on 02/11/2016 at 09:33:51 AM by jand
- Resolution set to fixed
- Status changed from new to closed
window.close logic is now encapsulated in setTimeout. This is not fixed on current release.
comment:6 Changed on 02/26/2016 at 02:05:58 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:7 Changed on 02/29/2016 at 10:27:32 AM by mario
- Milestone Adblock-Browser-for-iOS-next deleted
comment:8 Changed on 03/02/2016 at 02:48:07 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
Rebased the current release branch to include this ticket.
comment:9 Changed on 03/08/2016 at 06:47:27 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- Window.open is executed and the web page is opened. I tested this with a varying web pages as well as a locally hosted page supplied by jand.
ABP 1.3.0-qa (844)
iPhone 6 Plus - iOS 9.2.1
https://www.pivotaltracker.com/story/show/112582395